Fix pubber gateway proxy runtime issues#787
Merged
grafnu merged 15 commits intofaucetsdn:masterfrom Jan 26, 2024
Merged
Conversation
MertCingoz
force-pushed
the
pubber-fix
branch
from
f9bb0d6 to
eb55894
Compare
grafnu
reviewed
Jan 19, 2024
Collaborator
grafnu
left a comment
grafnu
left a comment
There was a problem hiding this comment.
Overall seems on track, I think most/all of the comments are local considerations.
validator/src/main/java/com/google/daq/mqtt/sequencer/SequenceBase.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/ConfigSequences.java
Show resolved
Hide resolved
grafnu
reviewed
Jan 23, 2024
Collaborator
grafnu
left a comment
grafnu
left a comment
There was a problem hiding this comment.
Looks like there's still some failing unit tests -- let me know if you have questions about what they mean. The tests can be a bit cryptic, but they are easy to fix.
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/ConfigSequences.java
Show resolved
Hide resolved
Collaborator
Author
|
Just reverted schema upgrade. Unit tests require manual upgrade of sample site model and trace files which I think it should be also handled in another PR |
MertCingoz
force-pushed
the
pubber-fix
branch
from
c244a6a to
dd04fb8
Compare
grafnu
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.