Fix publisher executor shutdown state

[MertCingoz]

No description provided.

[grafnu]

Overall technically this looks good, but what kind of testing have you been able to do on this? I took a quick look at your GitHub and it doesn't seem to be setup to run anything, and the upstream faucetsdn project doesn't run everything on a PR (security reasons, mainly)...

[MertCingoz]

@grafnu I have this issue again on local docker setup.

Steps to reproduce:
Local: After containers running and client connected, run registrar one more time.
Cloud: Connect client to MQTT broker then turn off wifi or ethernet adapter.

I hope we can now run local test on this repo. If not is there any guide how to setup CI to only run local test?

[grafnu]

There's the "always runs" CI setup at https://github.com/faucetsdn/udmi/blob/master/.github/workflows/testing.yml#L249 -- that'll show you the steps the CI testing does to setup a local run. there's a bin/setup_local script that does the needful. You can also set your TARGET_PROJET github repo actions variable to //mqtt/localhost and it should work, as per https://github.com/grafnu/udmi/settings/variables/actions (if you can see that, not sure) There's docs for containerized docker setup -- https://github.com/faucetsdn/udmi/blob/master/docs/udmis/local_docker.md (hot off the press, just did that yesterday) -- but that doesn't directly do CI testing yet... that's next.

…

On Mon, Jul 22, 2024 at 4:00 AM Mert Cingöz ***@***.***> wrote: @grafnu <https://github.com/grafnu> I have this issue again on local docker setup. Steps to reproduce: Local: After containers running and client connected, run registrar one more time. Cloud: Connect client to MQTT broker then turn off wifi or ethernet adapter. I hope we can now run local test on this repo. If not is there any guide how to setup CI to only run local test? — Reply to this email directly, view it on GitHub <#881 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIEPD5YNEDC35NRDU5C3HDZNTQ4TAVCNFSM6AAAAABHKV6536VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBSGY4DAMBZGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[MertCingoz]

I guess my Github username is not docker registry friendly.
https://github.com/MertCingoz/udmi/actions/runs/10042673525/job/27753661849

[grafnu]

LGTM. Reminder that for merging with master please remove all commit comments (just the PR title) when you squash-commit... the actual commit log (which is the default GitHub fills in) is pretty useless and just pollutes the commit log!