Skip to content

Publish validation events when running as validator with reflector#927

Merged
noursaidi merged 1 commit intofaucetsdn:masterfrom
noursaidi:reflectvalidation
Jul 10, 2024
Merged

Publish validation events when running as validator with reflector#927
noursaidi merged 1 commit intofaucetsdn:masterfrom
noursaidi:reflectvalidation

Conversation

@noursaidi
Copy link
Collaborator

@noursaidi noursaidi commented Jul 9, 2024

These were not published because the reflect client was not a data sink for validation events:

private void sendValidationMessage(String deviceId, Object message, String topic) {
    try {
      String messageString = OBJECT_MAPPER.writeValueAsString(message);
      dataSinks.forEach(sink -> sink.publish(deviceId, topic, messageString));
    } catch (Exception e) {
      throw new RuntimeException("While sending validation event for " + deviceId, e);
    }
  }

@noursaidi noursaidi requested a review from grafnu July 9, 2024 17:55
@noursaidi noursaidi merged commit 2dc6187 into faucetsdn:master Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants