Skip to content

Refactor Pubber to simplify downstream vendor modifications#993

Merged
erik-radixiot merged 11 commits intofaucetsdn:masterfrom
RadixIoT:feature/MANGO-1574/udmi-refactor-pr-for-upstream
Oct 21, 2024
Merged

Refactor Pubber to simplify downstream vendor modifications#993
erik-radixiot merged 11 commits intofaucetsdn:masterfrom
RadixIoT:feature/MANGO-1574/udmi-refactor-pr-for-upstream

Conversation

@erik-radixiot
Copy link
Collaborator

@erik-radixiot erik-radixiot commented Oct 18, 2024

Description

When upgrading from upstream latest Pubber version we noticed that it was pretty difficult to adapt to vendor needs, which requires a lot of diff and patching over two commits, with this changes we extracted some common methods into interfaces which will simplify the upgrade process for downstream upgrades to latest upstream UDMI.

Changes

  • Introduced provider interfaces in the .client package for every Manager with common methods extracted from the actual Managers that are shared among downstream vendor implementations.
  • Added some new getter and setter methods for private attributes shared with downstream vendor implementation.
  • Modified private fields to use interfaces instead of actual implementation of managers.
  • Moved some constants from the Manager classes to its parent interface.
  • Adapted test for these changes.
  • Fixed default socket factory when no TLS connect is specified.

@erik-radixiot erik-radixiot force-pushed the feature/MANGO-1574/udmi-refactor-pr-for-upstream branch from 9df6c69 to 5993094 Compare October 18, 2024 15:08
@erik-radixiot erik-radixiot marked this pull request as ready for review October 18, 2024 15:23
@erik-radixiot
Copy link
Collaborator Author

@grafnu requested changes are ready, please check.

@erik-radixiot erik-radixiot merged commit b6e3f5e into faucetsdn:master Oct 21, 2024
@erik-radixiot erik-radixiot deleted the feature/MANGO-1574/udmi-refactor-pr-for-upstream branch October 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants