Add schema push --stage #355
Conversation
macmv
requested review from
echo-bravo-yahoo,
freels,
henryfauna,
wdberkeley and
wildemat
macmv
force-pushed
the
add-schema-push-staged
branch
from
b3044e6 to
efae39e
Compare
freels
left a comment
freels
left a comment
There was a problem hiding this comment.
LGTM, would be good to get a DX team review
| // Confirm diff, then push it. `force` is set on `validate` so we don't | ||
| // need to pass the last known schema version through. | ||
| const params = new URLSearchParams({ | ||
| force: "true", | ||
| }); | ||
| const path = new URL(`/schema/1/validate?${params}`, url); |
There was a problem hiding this comment.
should we just drop the "force" param for validate?
There was a problem hiding this comment.
you can pass a version instead, so we just require force or version to be set on all the schema endpoints. we could probably drop it, it just keeps the validation simple in the core endpoint.
There was a problem hiding this comment.
right, just thinking it might make using the API itself simpler. I forget/lost track if we're actually passing version to validate at any point
There was a problem hiding this comment.
I need to double check, I think we might be using it in the dashboard to check if a schema version is stale. If we're not using it there, I'll go ahead and remove it from the core endpoint.
|
Looks like CI is failing on linting: |
|
well wait no, i haven't touched that code. that should be fine. |
macmv
force-pushed
the
add-schema-push-staged
branch
2 times, most recently
from
4ae4766 to
78cb6f1
Compare
| status: "complete", | ||
| }); | ||
|
|
||
| // But, the index should not be visible on the companion object. |
There was a problem hiding this comment.
+1 for comments with intent
macmv
force-pushed
the
add-schema-push-staged
branch
3 times, most recently
from
7758c38 to
a4267b8
Compare
|
ok, tests are now failing because the container is a bit out of date. they should start passing next week. |
macmv
force-pushed
the
add-schema-push-staged
branch
3 times, most recently
from
6126450 to
d66c2ca
Compare
macmv
changed the base branch from
main
to
nevermind-circle-ci-doesnt-have-outages
macmv
force-pushed
the
add-schema-push-staged
branch
from
d66c2ca to
4afab33
Compare
Ticket(s): ENG-6705
Adds
fauna schema push --stage. This doesn't hit the right endpoint for the non-force version quite yet (as that endpoint doesn't exist), but everything else is in place to push a staged schema.