Skip to content

Simplify flags to push and diff #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
macmv merged 2 commits into from
Oct 14, 2024
Merged

Simplify flags to push and diff #394

macmv merged 2 commits into from
Oct 14, 2024

Conversation

@macmv
Copy link
Contributor

@macmv macmv commented Oct 14, 2024

Ticket(s): ENG-6842

Renames push --skip-staged to push --active, and switches diff to take flags instead of an argument.

@echo-bravo-yahoo
Copy link
Contributor

echo-bravo-yahoo commented Oct 14, 2024

is the end state of this change that schema push and schema diff both use a flag --active|--staged that defaults to --staged?

@macmv macmv merged commit 0a4cd14 into main Oct 14, 2024
@macmv macmv deleted the update-flags branch October 14, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freels freels Awaiting requested review from freels

@echo-bravo-yahoo echo-bravo-yahoo Awaiting requested review from echo-bravo-yahoo

1 more reviewer

@wildemat wildemat wildemat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@macmv @echo-bravo-yahoo @wildemat