Bump dependency - allow click>=6.7,<=8.0#231
Merged
taybin merged 5 commits intofaust-streaming:masterfrom Dec 17, 2021
qbzenker:bump_click_8
Merged
Bump dependency - allow click>=6.7,<=8.0#231taybin merged 5 commits intofaust-streaming:masterfrom qbzenker:bump_click_8
click>=6.7,<=8.0#231taybin merged 5 commits intofaust-streaming:masterfrom
qbzenker:bump_click_8
Conversation
patkivikram
approved these changes
Dec 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 100 100
Lines 10762 10762
Branches 1472 1472
=======================================
Hits 10151 10151
Misses 542 542
Partials 69 69 Continue to review full report at Codecov.
|
Contributor
Author
|
Hey @patkivikram, could run the workflows and merge this PR when you feel ready? I would, but as a first-time committer to this repo, I don't have too many permissions. Thank you!! |
Contributor
Author
|
Any idea as to when this'll go in @patkivikram? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows for click version
<=8.0.Tested locally with various versions of
clickand all tests passed.See corresponding issue here: #230.