fix condition to delete old table keys#251
Merged
patkivikram merged 1 commit intofaust-streaming:masterfrom Jan 6, 2022
Merged
fix condition to delete old table keys#251patkivikram merged 1 commit intofaust-streaming:masterfrom
patkivikram merged 1 commit intofaust-streaming:masterfrom
Conversation
patkivikram
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When sending a single message,
on_window_closecallback is not triggered. It is triggered only after sending a second message to the stream.In _del_old_keys(), window.stale is always calculated based on
self._partition_latest_timestamp[partition]which will always be the same astimestamps[0]if there is only one message in stream:Related issue
Following the issue #250
Slack thread
Following the Slack discussion https://fauststream.slack.com/archives/C7FL9CB5E/p1641131986210500