Skip to content

Revert cancel getmany and add extra seek#256

Merged
patkivikram merged 3 commits intofaust-streaming:masterfrom
ekerstens:reseek_during_inactive_flow
Jan 11, 2022
Merged

Revert cancel getmany and add extra seek#256
patkivikram merged 3 commits intofaust-streaming:masterfrom
ekerstens:reseek_during_inactive_flow

Conversation

@ekerstens
Copy link
Contributor

@ekerstens ekerstens commented Jan 11, 2022

Description

  • Revert Stop fetching when flow stops #253 because task cancellation did not propagate to the service thread, resulting in orphaned fetchers continuing to fetch without returning to anything.
  • Add extra check to _wait_next_records to make sure flow is actually resumed before continuing
  • Reseek to committed offsets if getmany completes while flow is not active.

@patkivikram patkivikram merged commit a7256eb into faust-streaming:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants