fix name_prefix usage#266
Merged
patkivikram merged 1 commit intofaust-streaming:masterfrom Feb 23, 2022
Merged
Conversation
jsurloppe
force-pushed
the
prometheus-prefix-fix
branch
from
5efb9cd to
d3fd3d8
Compare
app name is used as fallback only if it contains dash plus lot of cases lead to prometheus naming exception simplify it by enforcing correct prometheus naming
jsurloppe
force-pushed
the
prometheus-prefix-fix
branch
from
d3fd3d8 to
2f7a8dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 94.23% 94.26% +0.02%
==========================================
Files 100 100
Lines 10829 10826 -3
Branches 1479 1478 -1
==========================================
Hits 10205 10205
+ Misses 553 550 -3
Partials 71 71
Continue to review full report at Codecov.
|
patkivikram
approved these changes
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app name is used as fallback only if it contains dash
plus lot of cases lead to prometheus naming exception
simplify it by enforcing correct prometheus naming