Additional broker configs #278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* connections_max_idle * metadata_max_age
patkivikram
approved these changes
Mar 6, 2022
Contributor
Author
|
@patkivikram Hi, thanks for approving! But didn't quite understand if it passed the linting step or not. Did another commit to fix that, to make them look as all other settings. Or is it already merged? |
Collaborator
|
looks like there are some conflicts. Can you fix that and push your changes? |
Contributor
|
This PR duplicates some of settings already merged in #279. Can you check this? |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Need a way to specify aiokafka.consumer and .producer settings connections_max_idle_ms and metadata_max_age_ms