Skip to content

Start testing table.last_closed_window#391

Merged
wbarnha merged 3 commits intofaust-streaming:masterfrom
wbarnha:test_last_closed_window
Oct 24, 2022
Merged

Start testing table.last_closed_window#391
wbarnha merged 3 commits intofaust-streaming:masterfrom
wbarnha:test_last_closed_window

Conversation

@wbarnha
Copy link
Copy Markdown
Member

@wbarnha wbarnha commented Oct 19, 2022

Hopefully this will clarify things for #381.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 92.96% // Head: 94.03% // Increases project coverage by +1.07% 🎉

Coverage data is based on head (ff14a02) compared to base (73e4400).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   92.96%   94.03%   +1.07%     
==========================================
  Files         102      102              
  Lines       11069    11073       +4     
  Branches     1263     1297      +34     
==========================================
+ Hits        10290    10413     +123     
+ Misses        702      582     -120     
- Partials       77       78       +1     
Impacted Files Coverage Δ
faust/agents/replies.py 100.00% <0.00%> (ø)
faust/transport/consumer.py 94.33% <0.00%> (+<0.01%) ⬆️
faust/transport/drivers/aiokafka.py 74.10% <0.00%> (+0.03%) ⬆️
faust/transport/producer.py 89.16% <0.00%> (+0.09%) ⬆️
faust/transport/conductor.py 100.00% <0.00%> (+1.41%) ⬆️
faust/streams.py 88.01% <0.00%> (+15.75%) ⬆️
faust/windows.py 100.00% <0.00%> (+43.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wbarnha wbarnha marked this pull request as ready for review October 24, 2022 18:42
@wbarnha wbarnha merged commit 6a1a940 into faust-streaming:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants