Skip to content

Use setuptools_scm to automate versioning#407

Merged
wbarnha merged 16 commits into
faust-streaming:masterfrom
wbarnha:use-setuptools_scm
Nov 4, 2022
Merged

Use setuptools_scm to automate versioning#407
wbarnha merged 16 commits into
faust-streaming:masterfrom
wbarnha:use-setuptools_scm

Conversation

@wbarnha
Copy link
Copy Markdown
Member

@wbarnha wbarnha commented Nov 4, 2022

Closes #406.

Still not done yet because I need the version in https://github.com/faust-streaming/faust/blob/master/docs/includes/tags.txt to automatically update.

I'm also removing the publish script since we're standardizing releases through Github Releases from hereon.

Before merging this, I'd like to use setuptools_scm in a non-deprecated way as well, by having it outside of setup.py and in setup.cfg.

@wbarnha
Copy link
Copy Markdown
Member Author

wbarnha commented Nov 4, 2022

Apparently usage of setuptools_scm in setup.py and setup.cfg is deprecated, we'd have to make a pyproject.toml file.

@wbarnha
Copy link
Copy Markdown
Member Author

wbarnha commented Nov 4, 2022

Should probably remove bumpversion as well.

@wbarnha
Copy link
Copy Markdown
Member Author

wbarnha commented Nov 4, 2022

https://wbarnha.github.io/faust/introduction.html looks good. Just need to make sure we issue a release shortly after merging this to ensure PyPi info is correct.

@wbarnha wbarnha changed the title Use setuptools scm Use setuptools_scm to automate versioning Nov 4, 2022
@wbarnha wbarnha marked this pull request as ready for review November 4, 2022 03:30
@wbarnha
Copy link
Copy Markdown
Member Author

wbarnha commented Nov 4, 2022

Before merging this, I should verify releases to PyPi work properly.

@wbarnha
Copy link
Copy Markdown
Member Author

wbarnha commented Nov 4, 2022

PyPi test release successful. LGTM.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 94.02% // Head: 92.91% // Decreases project coverage by -1.11% ⚠️

Coverage data is based on head (b1fe48b) compared to base (90be0cc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   94.02%   92.91%   -1.12%     
==========================================
  Files         102      102              
  Lines       11076    11076              
  Branches     1298     1258      -40     
==========================================
- Hits        10414    10291     -123     
- Misses        583      705     +122     
- Partials       79       80       +1     
Impacted Files Coverage Δ
faust/__init__.py 100.00% <100.00%> (ø)
faust/windows.py 56.89% <0.00%> (-43.11%) ⬇️
faust/streams.py 72.26% <0.00%> (-15.76%) ⬇️
faust/transport/conductor.py 98.58% <0.00%> (-1.42%) ⬇️
faust/models/typing.py 94.36% <0.00%> (-0.94%) ⬇️
faust/livecheck/patches/aiohttp.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wbarnha wbarnha merged commit 775816c into faust-streaming:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use setuptools_scm to automatically detect version

2 participants