Skip to content

Fix vector order#2

Merged
faustomorales merged 10 commits intomasterfrom
fdm/fix-vector-order
Nov 14, 2020
Merged

Fix vector order#2
faustomorales merged 10 commits intomasterfrom
fdm/fix-vector-order

Conversation

@faustomorales
Copy link
Copy Markdown
Owner

Closes #1

This change does the following:

  • Bumps the underlying ThreatExchange repository version to use the most recent.
  • Fixes the vector order to match ThreatExchange as described in the linked issue.
  • Uses the updated bit arrays with the correct order.
  • Adds a warning for users indicating that the vector shape changed in the new version and points them to the issue for more context.

@faustomorales faustomorales merged commit 871f238 into master Nov 14, 2020
@faustomorales faustomorales deleted the fdm/fix-vector-order branch November 14, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hash 'word' order in reverse order compared to ThreatExchange/pdq/ (local order of each 16 bit section is correct)

1 participant