StreamReader: Don't hang on to fully read buffers#6
Merged
jcoglan merged 1 commit intofaye:masterfrom May 7, 2014
Merged
Conversation
jcoglan
added a commit
that referenced
this pull request
May 7, 2014
StreamReader: Don't hang on to fully read buffers
Collaborator
|
Thanks for the patch. It's made me realise this code could be written in a far less obtuse way; I'll push a fix shortly. |
Collaborator
|
This refactoring cleans up the cursor logic and still drops buffers once fully read: |
Collaborator
|
This is now released in 0.3.4. |
glasser
added a commit
to meteor/meteor
that referenced
this pull request
May 22, 2014
The websocket-driver update includes our PR to relinquish some memory faster. faye/websocket-driver-node#6 The sockjs update mostly consists of aligning the version of faye-websocket it uses internally with the version that we use for our client. It also contains this Vary: Origin change: sockjs/sockjs-node#130
glasser
added a commit
to meteor/meteor
that referenced
this pull request
Jun 2, 2014
The websocket-driver update includes our PR to relinquish some memory faster. faye/websocket-driver-node#6 The sockjs update mostly consists of aligning the version of faye-websocket it uses internally with the version that we use for our client. It also contains this Vary: Origin change: sockjs/sockjs-node#130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a socket leak in our app, and we noticed that all the sockets (despite being inactive and fully parsed) were hanging on to a buffer in queue[0]. Now, on the one hand, it was kind of nice to make the leak more obvious by inflating it :) but it should probably be fixed.