Skip to content

Comments

chore(lint): Use shared eslint config#2358

Open
fb55 wants to merge 4 commits intomasterfrom
shared-config
Open

chore(lint): Use shared eslint config#2358
fb55 wants to merge 4 commits intomasterfrom
shared-config

Conversation

@fb55
Copy link
Owner

@fb55 fb55 commented Feb 21, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 21, 2026 23:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s linting/formatting setup to use a shared ESLint config and Biome, with resulting import/order formatting changes across source and test files.

Changes:

  • Switched ESLint configuration to @feedic/eslint-config and trimmed local rule definitions.
  • Replaced Prettier formatting scripts/config with Biome (biome.json, new npm scripts).
  • Applied formatting/import-order updates across TS sources/tests; changed const enum to runtime enum in the tokenizer.

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/index.ts Reorders exports/imports to match new lint/format rules.
src/index.spec.ts Import ordering and Promise construction formatting updates.
src/fixtures/testHelper.ts Import ordering update.
src/WritableStream.ts Import ordering update.
src/WritableStream.spec.ts Import ordering update.
src/Tokenizer.ts Converts const enum to enum to satisfy lint/format constraints.
src/Tokenizer.spec.ts Import ordering update.
src/Parser.ts Import ordering update.
src/Parser.spec.ts Import ordering update.
src/Parser.events.spec.ts Import ordering update.
src/FeedHandler.spec.ts Import ordering update.
package.json Swaps Prettier for Biome scripts; adopts shared ESLint config dependency.
eslint.config.mjs Replaces local flat config with shared @feedic/eslint-config and common TS rules.
biome.json Adds Biome configuration for formatting/linting/import organization.
Comments suppressed due to low confidence (1)

eslint.config.mjs:1

  • This config still references n/* and unicorn/* rules, but eslint-plugin-n and eslint-plugin-unicorn were removed from package.json. Unless @feedic/eslint-config provides (and registers) these plugins, ESLint will error with 'Definition for rule ... was not found'. Either re-add the plugins as devDependencies/ensure they’re included as dependencies, or remove these plugin-specific rule overrides.
import { defineConfig } from "eslint/config";

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant