Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s linting/formatting setup to use a shared ESLint config and Biome, with resulting import/order formatting changes across source and test files.
Changes:
- Switched ESLint configuration to
@feedic/eslint-configand trimmed local rule definitions. - Replaced Prettier formatting scripts/config with Biome (
biome.json, new npm scripts). - Applied formatting/import-order updates across TS sources/tests; changed
const enumto runtimeenumin the tokenizer.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Reorders exports/imports to match new lint/format rules. |
| src/index.spec.ts | Import ordering and Promise construction formatting updates. |
| src/fixtures/testHelper.ts | Import ordering update. |
| src/WritableStream.ts | Import ordering update. |
| src/WritableStream.spec.ts | Import ordering update. |
| src/Tokenizer.ts | Converts const enum to enum to satisfy lint/format constraints. |
| src/Tokenizer.spec.ts | Import ordering update. |
| src/Parser.ts | Import ordering update. |
| src/Parser.spec.ts | Import ordering update. |
| src/Parser.events.spec.ts | Import ordering update. |
| src/FeedHandler.spec.ts | Import ordering update. |
| package.json | Swaps Prettier for Biome scripts; adopts shared ESLint config dependency. |
| eslint.config.mjs | Replaces local flat config with shared @feedic/eslint-config and common TS rules. |
| biome.json | Adds Biome configuration for formatting/linting/import organization. |
Comments suppressed due to low confidence (1)
eslint.config.mjs:1
- This config still references
n/*andunicorn/*rules, buteslint-plugin-nandeslint-plugin-unicornwere removed frompackage.json. Unless@feedic/eslint-configprovides (and registers) these plugins, ESLint will error with 'Definition for rule ... was not found'. Either re-add the plugins as devDependencies/ensure they’re included as dependencies, or remove these plugin-specific rule overrides.
import { defineConfig } from "eslint/config";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.