Skip to content

Reorganize note dialog buttons (issue #133)#141

Merged
fboucher merged 3 commits into
v-nextfrom
feature/133-move-remove-buttons
May 20, 2026
Merged

Reorganize note dialog buttons (issue #133)#141
fboucher merged 3 commits into
v-nextfrom
feature/133-move-remove-buttons

Conversation

@fboucher
Copy link
Copy Markdown
Owner

Changes

  • Move Delete button to bottom left (only shown in edit mode)
  • Move Cancel and Save buttons to bottom right
  • Add proper CSS styling for flexbox layout

Issue Resolution

Addresses #133: Move and remove buttons in the note dialog

Testing

  • Build verified successfully
  • SharedUI component compiles without errors
  • Button layout reorganized per specifications

fboucher and others added 3 commits May 20, 2026 07:14
- Move Delete button to bottom left (only in edit mode)
- Move Cancel and Save buttons to bottom right
- Add CSS styling for proper footer layout with flexbox
- Delete button appears on left, Cancel and Save on right

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Updated tests to render NoteDialog through NoteDialogTestWrapper
- NoteDialogTestWrapper provides FluentDialog cascading context required by FluentDialogFooter
- Updated test expectations for current button layout (Delete, Save, Cancel)
- All NoteDialog tests now pass: form fields rendering, button visibility, tags handling, categories

Fixes regression tests broken by switch to FluentDialogFooter component in issue #133

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
NoteBookmark.AIServices 97% 64%
NoteBookmark.Api 91% 80%
NoteBookmark.BlazorApp 4% 8%
NoteBookmark.Domain 86% 75%
NoteBookmark.ServiceDefaults 96% 75%
NoteBookmark.SharedUI 7% 7%
Summary 53% (865 / 1621) 43% (202 / 473)

@fboucher fboucher changed the base branch from main to v-next May 20, 2026 12:18
@fboucher fboucher merged commit 2c599c2 into v-next May 20, 2026
3 checks passed
@fboucher fboucher deleted the feature/133-move-remove-buttons branch May 20, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant