Skip to content

fix cascading ...#419

Merged
fccview merged 1 commit intofccview:developfrom
spaghetti-coder:cascade-checkbox
Feb 16, 2026
Merged

fix cascading ...#419
fccview merged 1 commit intofccview:developfrom
spaghetti-coder:cascade-checkbox

Conversation

@spaghetti-coder
Copy link
Copy Markdown
Contributor

@spaghetti-coder spaghetti-coder commented Feb 15, 2026

  • fix cascade nested checkbox toggle
  • fix unchecing single sub-item in kamban card doesn't uncheck parent

Closes #418

@spaghetti-coder spaghetti-coder force-pushed the cascade-checkbox branch 2 times, most recently from 21f1d29 to 34a3393 Compare February 15, 2026 20:14
@fccview
Copy link
Copy Markdown
Owner

fccview commented Feb 15, 2026

Thank you so much!
Gonna review in the morning ❤️

Sorry about the tests failing, I'm doing some cleaning up and I wanted to push what I have so far, I'll sort it all in the morning too ❤️

@spaghetti-coder
Copy link
Copy Markdown
Contributor Author

spaghetti-coder commented Feb 15, 2026

Hey @fccview,
No hurry here.

Just wanted to mention that fixed one more issue with kanban card subtasks.

  • A
    • B
    • C

With these subtasks if I uncheck C, A remains checked. This was caused by areAnyItemsCompleted check. Removed it everywhere because parent node completion depends only whether all its sub-items are checked (that's the actual check) or not. Some or none - doesn't matter, it's either all or not all

@spaghetti-coder spaghetti-coder force-pushed the cascade-checkbox branch 2 times, most recently from d04b130 to 85b5828 Compare February 16, 2026 08:09
@fccview
Copy link
Copy Markdown
Owner

fccview commented Feb 16, 2026

I see you are still committing things, let me know when you are happy for me to review!

If you merge develop into your branch tests should be fixed now and your pipeline will go all green ♥️

@spaghetti-coder
Copy link
Copy Markdown
Contributor Author

spaghetti-coder commented Feb 16, 2026

Yeah, just made some refactoring. Now all is done.
Tests are still failing though, looks like caused by my changes. Will take a look a bit later

@spaghetti-coder
fix cascading ...
4d1c2f8 
* fix cascade nested checkbox toggle
* fix unchecing single sub-item in kamban card doesn't uncheck parent
* remove "any items completed" check for list sub-items
* update tests
@spaghetti-coder
Copy link
Copy Markdown
Contributor Author

spaghetti-coder commented Feb 16, 2026

Hey, I'm done here :)

@fccview fccview merged commit f8b6ff3 into fccview:develop Feb 16, 2026
2 checks passed
@fccview
Copy link
Copy Markdown
Owner

fccview commented Feb 16, 2026

All looking good, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spaghetti-coder @fccview