Skip to content

Add std::vector of core classes to LinkDef#57

Merged
jbeirer merged 1 commit into
mainfrom
main-addVecLinkdef
Feb 23, 2025
Merged

Add std::vector of core classes to LinkDef#57
jbeirer merged 1 commit into
mainfrom
main-addVecLinkdef

Conversation

@jbeirer
Copy link
Copy Markdown
Collaborator

@jbeirer jbeirer commented Feb 23, 2025

This PR adds pragma linkage directives for TFCSTruthState, TFCSExtrapolationState, and TFCSSimulationState, such that we can save std::vectors of these objects into ROOT files, needed for https://github.com/fcs-proj/DDFastCaloSim implementation of the parametrization

Summary by CodeRabbit

  • Chores
    • Enhanced internal support for managing collections of simulation state objects to streamline simulation workflows.
    • Upgraded the system to handle grouped simulation data more efficiently, contributing to improved performance and reliability.
    • Overall, these updates help ensure a smoother and more robust simulation environment for end-users.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 23, 2025

Walkthrough

The changes add three new pragma linkage directives in the FastCaloSim project's LinkDef header. These directives enable the ROOT dictionary generation for vector containers holding instances of the classes TFCSTruthState, TFCSExtrapolationState, and TFCSSimulationState, ensuring that these vectors can be used properly in the context of FastCaloSim.

Changes

File Change Summary
include/FastCaloSim/LinkDef.h Added linkage directives for std::vector<TFCSTruthState>, std::vector<TFCSExtrapolationState>, and std::vector<TFCSSimulationState>, enhancing vector support.

Poem

Oh, what a hop, the code sings anew,
Vectors now dance with each state in view,
TFCSTruthState, Extrapolation, Simulation in line,
Linked in a dance so sleek and fine.
This rabbit cheers with a joyful carrot shine!
🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c0cf26 and d0668e3.

📒 Files selected for processing (1)
  • include/FastCaloSim/LinkDef.h (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: lint
🔇 Additional comments (1)
include/FastCaloSim/LinkDef.h (1)

642-644: LGTM! The vector linkage directives are correctly added.

The addition of these pragma directives enables ROOT dictionary generation for vector containers of the core state classes. This is a necessary and common pattern in ROOT-based projects for proper serialization/deserialization of vectors containing these objects.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

see 2 files with indirect coverage changes

@jbeirer jbeirer merged commit 2a45381 into main Feb 23, 2025
@jbeirer jbeirer deleted the main-addVecLinkdef branch February 23, 2025 11:40
@coderabbitai coderabbitai Bot mentioned this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant