Conversation
Refactored `Codings`, `Sites`, `Forms`, `Variables`, and `Intervals` endpoints to use new `StrictListGetEndpoint` and `MetadataListGetEndpoint` abstractions in `imednet/core/endpoint/mixins/bases.py`. This removes duplicated configuration for study filtering and page sizing. Also refactored `JobPoller` in `imednet/workflows/job_poller.py` to extract common logic for timeout and status checking into helper methods, reducing duplication between sync and async polling loops. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
fderuiter
deleted the
refactor/endpoints-jobpoller-12750604503225548045
branch
1 participant
StrictListGetEndpointandMetadataListGetEndpointtoimednet/core/endpoint/mixins/bases.py.CodingsEndpointandSitesEndpointto inherit fromStrictListGetEndpoint.FormsEndpoint,VariablesEndpoint, andIntervalsEndpointto inherit fromMetadataListGetEndpoint.JobPollerto use_check_timeoutand_check_completehelpers.PR created automatically by Jules for task 12750604503225548045 started by @fderuiter