🏗️ Architect: Refactor RequestExecutor for Modularity#680
Conversation
Refactored the `RequestExecutor` class into a class hierarchy (`BaseRequestExecutor`, `SyncRequestExecutor`, `AsyncRequestExecutor`) to separate synchronous and asynchronous logic, adhering to the Single Responsibility Principle. Changes: - Created `imednet/core/http/executor.py` with `BaseRequestExecutor`, `SyncRequestExecutor`, and `AsyncRequestExecutor`. - Updated `imednet/core/http_client_base.py` to use dependency injection for the executor class via `EXECUTOR_CLS`. - Updated `imednet/core/client.py` to use `SyncRequestExecutor`. - Updated `imednet/core/async_client.py` to use `AsyncRequestExecutor`. - Updated tests to reflect these changes. This change eliminates runtime `is_async` checks in the executor and allows for better type safety and extensibility. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Refactored the
RequestExecutorclass into a class hierarchy (BaseRequestExecutor,SyncRequestExecutor,AsyncRequestExecutor) to separate synchronous and asynchronous logic, adhering to the Single Responsibility Principle.Changes:
imednet/core/http/executor.pywithBaseRequestExecutor,SyncRequestExecutor, andAsyncRequestExecutor.imednet/core/http_client_base.pyto use dependency injection for the executor class viaEXECUTOR_CLS.imednet/core/client.pyto useSyncRequestExecutor.imednet/core/async_client.pyto useAsyncRequestExecutor.This change eliminates runtime
is_asyncchecks in the executor and allows for better type safety and extensibility.PR created automatically by Jules for task 6890428304471025114 started by @fderuiter