Skip to content

🏗️ Architect: Refactor RequestExecutor for Modularity#680

Merged
fderuiter merged 1 commit intomainfrom
architect-refactor-executor-6890428304471025114
Feb 19, 2026
Merged

🏗️ Architect: Refactor RequestExecutor for Modularity#680
fderuiter merged 1 commit intomainfrom
architect-refactor-executor-6890428304471025114

Conversation

@fderuiter
Copy link
Copy Markdown
Owner

Refactored the RequestExecutor class into a class hierarchy (BaseRequestExecutor, SyncRequestExecutor, AsyncRequestExecutor) to separate synchronous and asynchronous logic, adhering to the Single Responsibility Principle.

Changes:

  • Created imednet/core/http/executor.py with BaseRequestExecutor, SyncRequestExecutor, and AsyncRequestExecutor.
  • Updated imednet/core/http_client_base.py to use dependency injection for the executor class via EXECUTOR_CLS.
  • Updated imednet/core/client.py to use SyncRequestExecutor.
  • Updated imednet/core/async_client.py to use AsyncRequestExecutor.
  • Updated tests to reflect these changes.

This change eliminates runtime is_async checks in the executor and allows for better type safety and extensibility.


PR created automatically by Jules for task 6890428304471025114 started by @fderuiter

Refactored the `RequestExecutor` class into a class hierarchy (`BaseRequestExecutor`, `SyncRequestExecutor`, `AsyncRequestExecutor`) to separate synchronous and asynchronous logic, adhering to the Single Responsibility Principle.

Changes:
- Created `imednet/core/http/executor.py` with `BaseRequestExecutor`, `SyncRequestExecutor`, and `AsyncRequestExecutor`.
- Updated `imednet/core/http_client_base.py` to use dependency injection for the executor class via `EXECUTOR_CLS`.
- Updated `imednet/core/client.py` to use `SyncRequestExecutor`.
- Updated `imednet/core/async_client.py` to use `AsyncRequestExecutor`.
- Updated tests to reflect these changes.

This change eliminates runtime `is_async` checks in the executor and allows for better type safety and extensibility.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@fderuiter fderuiter marked this pull request as ready for review February 19, 2026 19:25
@fderuiter fderuiter merged commit 94bc2c1 into main Feb 19, 2026
13 checks passed
@fderuiter fderuiter deleted the architect-refactor-executor-6890428304471025114 branch February 19, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant