Skip to content

๐Ÿ› ๏ธ Refactor: SDK Core - Remove obsolete legacy endpoint base classes#737

Merged
fderuiter merged 1 commit intomainfrom
refactor/remove-legacy-endpoint-base-classes-2424322300472974071
Mar 28, 2026
Merged

๐Ÿ› ๏ธ Refactor: SDK Core - Remove obsolete legacy endpoint base classes#737
fderuiter merged 1 commit intomainfrom
refactor/remove-legacy-endpoint-base-classes-2424322300472974071

Conversation

@fderuiter
Copy link
Copy Markdown
Owner

๐Ÿ› ๏ธ Refactor: SDK Core - Remove obsolete legacy endpoint base classes

Removed obsolete base classes (ListEndpoint, ListGetEndpoint, ListPathGetEndpoint, StrictListGetEndpoint, MetadataListGetEndpoint, and BaseEndpoint) from src/imednet/core/endpoint/mixins/bases.py and src/imednet/core/endpoint/base.py. These legacy wrappers added no functionality over their EDC equivalents and created an unnecessary inheritance layer.

Updated tests in test_base_endpoint.py and test_security_path_traversal.py to directly inherit GenericEndpoint combined with EdcEndpointMixin instead of using the deleted BaseEndpoint.

Cleaned up __init__.py module exports and removed related monkeypatch logic from tests/conftest.py.


PR created automatically by Jules for task 2424322300472974071 started by @fderuiter

Removed obsolete base classes (`ListEndpoint`, `ListGetEndpoint`, `ListPathGetEndpoint`, `StrictListGetEndpoint`, `MetadataListGetEndpoint`, and `BaseEndpoint`) from `src/imednet/core/endpoint/mixins/bases.py` and `src/imednet/core/endpoint/base.py`. These legacy wrappers added no functionality over their EDC equivalents and created an unnecessary inheritance layer.

Updated tests in `test_base_endpoint.py` and `test_security_path_traversal.py` to directly inherit `GenericEndpoint` combined with `EdcEndpointMixin` instead of using the deleted `BaseEndpoint`.

Cleaned up `__init__.py` module exports and removed related monkeypatch logic from `tests/conftest.py`.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@fderuiter fderuiter marked this pull request as ready for review March 28, 2026 00:46
@fderuiter fderuiter merged commit 68849a3 into main Mar 28, 2026
13 checks passed
@fderuiter fderuiter deleted the refactor/remove-legacy-endpoint-base-classes-2424322300472974071 branch March 28, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant