Skip to content

🛠️ Refactor: Fix MRO for GenericListGetEndpoint and JobsEndpoint#838

Merged
fderuiter merged 1 commit intomainfrom
refactor/fix-mro-9523091221483086699
Apr 28, 2026
Merged

🛠️ Refactor: Fix MRO for GenericListGetEndpoint and JobsEndpoint#838
fderuiter merged 1 commit intomainfrom
refactor/fix-mro-9523091221483086699

Conversation

@fderuiter
Copy link
Copy Markdown
Owner

🛠️ Refactor: Core Endpoints - Method Resolution Order (MRO) Fix

♻️ DRY: Ensured mixins can properly override generic base class methods without shadowing issues, allowing shared method logic to flow correctly.
🧱 SOLID: Improved inheritance structure in GenericListGetEndpoint and JobsEndpoint to align with standard Python mixin behavior.
📉 Diff: Minor ordering changes in class definitions.

Fixes the MRO in src/imednet/core/endpoint/base.py and src/imednet/endpoints/jobs.py to prevent base classes from shadowing mixins.


PR created automatically by Jules for task 9523091221483086699 started by @fderuiter

Moved mixins to appear before the generic base classes in `GenericListGetEndpoint` and `JobsEndpoint` to ensure proper method overriding and inheritance flow.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@fderuiter fderuiter marked this pull request as ready for review April 28, 2026 23:55
@fderuiter fderuiter merged commit 652f965 into main Apr 28, 2026
13 checks passed
@fderuiter fderuiter deleted the refactor/fix-mro-9523091221483086699 branch April 28, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant