Conversation
Replaced @Property for requires_study_key with type-hinted class attributes in EndpointABC and StudiesEndpoint. This prevents MRO shadowing issues and simplifies endpoint configuration. Also updated unit tests to evaluate flags on instances rather than classes to ensure proper resolution. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
fderuiter
deleted the
architect-endpoints-fix-property-overriding-6777910474801290279
branch
1 participant
🏛️ Design Change:
Converted
requires_study_keyfrom a@propertyinEndpointABCto a properly type-hinted class attribute. This fixes MRO shadowing issues where overriding the property with a class attribute in subclasses or mixins would cause issues.♻️ DRY Gains:
Simplified configuration across endpoints, avoiding verbose
@propertyoverrides for a simple boolean flag.🛡️ Solidity:
Improved type safety and predictability. Fixed tests in
test_list_get.pyto evaluate the attribute on the instance (ep) rather than the class (cls), ensuring proper resolution of overridden values (previously it inadvertently worked by returning truthy property objects).None. The public interface and behavior remain exactly the same.
PR created automatically by Jules for task 6777910474801290279 started by @fderuiter