Skip to content

Move TFDV stats fields on FeatureSpec proto to higher-numbered fields #667

@ches

Description

@ches

As discussed at #655 (comment) and according to protobuf spec guidance:

…field numbers in the range 1 through 15 take one byte to encode, including the field number and the field's type (you can find out more about this in Protocol Buffer Encoding). Field numbers in the range 16 through 2047 take two bytes. So you should reserve the numbers 1 through 15 for very frequently occurring message elements. Remember to leave some room for frequently occurring elements that might be added in the future.

Although FeatureSpec is registry (meta)data that is not used in high-throughput RPCs or Kafka messages currently, it doesn't seem like a bad idea to move the TFDV stats and reserve low-number fields while we can. The cost is low.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions