Skip to content

Conversation

@Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Jan 19, 2020

What this PR does / why we need it:
Seems there're a few breaking changes recently and contributing doc is broken.

Which issue(s) this PR fixes:
Fixes #436

Does this PR introduce a user-facing change?:
NONE

Fix broken contributing doc

@feast-ci-bot
Copy link
Collaborator

Hi @Jeffwan. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Member

woop commented Jan 19, 2020

Thanks for the contribution @Jeffwan!

woop
woop previously approved these changes Jan 19, 2020
@woop
Copy link
Member

woop commented Jan 19, 2020

/lgtm

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jan 19, 2020

/hold

Please do not merge and this is in progress.

@woop
Copy link
Member

woop commented Jan 19, 2020

/hold

Please do not merge and this is in progress.

Noted!

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jan 19, 2020

@woop Please have another review.

@Jeffwan Jeffwan force-pushed the fix_contributing_doc branch from 040c638 to b58b6a6 Compare January 21, 2020 20:41
@Jeffwan Jeffwan force-pushed the fix_contributing_doc branch from b58b6a6 to 9453977 Compare January 23, 2020 02:08
@Jeffwan Jeffwan requested a review from woop January 23, 2020 02:09
@woop
Copy link
Member

woop commented Jan 26, 2020

@Jeffwan would you mind removing the hold? I am assuming you are ready to merge :)

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jan 27, 2020

/hold cancel

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jan 27, 2020

@woop Yeah, I just remove it. Thanks for reminder.

@khorshuheng
Copy link
Collaborator

/ok-to-test

@woop
Copy link
Member

woop commented Jan 29, 2020

/lgtm
/approved

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 4cd928d into feast-dev:master Jan 29, 2020
@Jeffwan Jeffwan deleted the fix_contributing_doc branch February 2, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contributing Instruction is broken

5 participants