-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix broken contributing doc #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Jeffwan. Thanks for your PR. I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks for the contribution @Jeffwan! |
|
/lgtm |
|
/hold Please do not merge and this is in progress. |
Noted! |
62d3d8c to
040c638
Compare
|
@woop Please have another review. |
040c638 to
b58b6a6
Compare
b58b6a6 to
9453977
Compare
|
@Jeffwan would you mind removing the hold? I am assuming you are ready to merge :) |
|
/hold cancel |
|
@woop Yeah, I just remove it. Thanks for reminder. |
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan, woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Seems there're a few breaking changes recently and contributing doc is broken.
Which issue(s) this PR fixes:
Fixes #436
Does this PR introduce a user-facing change?:
NONE