-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add support for storing spring profiles as kubernetes secrets #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Enable deployment rollout on configmap / secret changes Move store.yaml into a new configmap as it is already reloaded at runtime
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pmjacinto The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @pmjacinto. Thanks for your PR. I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks for the submission @pmjacinto! Quick question: Have you signed the CLA? |
|
/ok-to-test |
Hey @woop Yes, I've signed the google CLA. |
|
/assign @pradithya |
|
Haven't had time to review this yet. Please bear with us :) |
|
@pmjacinto would be great to get your take on #533. Especially because it now tries to solve the secrets problem as well. |
|
@pmjacinto I believe this functionality is now covered by #533. Please let us know if you think it should be reopened. Really do appreciate the effort you put in here. |
What this PR does / why we need it:
store.yamlinto a new configmap as it does not require a pod restart to reloadWhich issue(s) this PR fixes:
General reliability improvements.
Does this PR introduce a user-facing change?:
feast-*.springSecretProfilesandfeast-*.springSecretProfilesActivewere added tovalues.yaml. No helm chart values update required in order to keep the current behaviour.To compare the Helm output of these changes with the previous version, these commands can be used.