[WIP] Clean up Feast configuration #604
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woop
commented
Apr 4, 2020
woop
commented
Apr 4, 2020
core/src/main/java/feast/core/service/JobCoordinatorService.java
Outdated
Show resolved
Hide resolved
zhilingc
force-pushed
the
storage-refactor
branch
from
295a772 to
fa87a42
Compare
…east-dev#567) * Add storage interfaces, basic file structure (feast-dev#529) * Add storage interfaces, basic file structure * Apply spotless, add comments * Move parseResponse and isEmpty to response object * Make changes to write interface to be more beam-like * Pass feature specs to the retriever * Pass feature specs to online retriever * Add FeatureSetRequest * Add mistakenly removed TestUtil * Add mistakenly removed TestUtil * Add BigQuery storage (feast-dev#546) * Add Redis storage implementation (feast-dev#547) * Add Redis storage * Remove staleness check; can be checked at the service level * Remove staleness related tests * Add dependencies to top level pom * Clean up code * Change serving and ingestion to use storage API (feast-dev#553) * Change serving and ingestion to use storage API * Remove extra exclusion clause * Storage refactor API and docstring tweaks (feast-dev#569) * API and docstring tweaks * Fix javadoc linting errors * Apply spotless * Fix javadoc formatting * Drop result from HistoricalRetrievalResult constructors * Change pipeline to use DeadletterSink API (feast-dev#586) * Add better code docs to storage refactor (feast-dev#601) * Add better code documentation, make GetFeastServingInfo independent of retriever * Make getStagingLocation method of historical retriever * Apply spotless * Clean up dependencies, remove exclusions at serving (feast-dev#607) * Clean up OnlineServingService code (feast-dev#605) * Clean up OnlineServingService code to be more readable * Revert Metrics * Rename storage API packages to nouns
…adata (feast-dev#450) * Add skeleton for update/get schema in FeatureSet * Add update_schema method to FeatureSet - Update Field, Feature and Entity class with fields from presence_constraints, shape_type and domain_info * Update error message when domain ref is missing from top level schema * Add more assertion in test_update_schema before updating schema * Fix conflicting versions in package requirements * Add export_schema method to export schema from FeatureSet * Add exporting of Tensorflow metadata schema from FeatureSet. - Update documentation for properties in Field - Deduplication refactoring in FeatureSet * Remove changes to mypy generated codes * Revert changes to packages version in requirements-ci and setup.py They are not necessary for now and to avoid unexpected breaking changes. * Remove 'schema' param in 'from_proto' method in Entity and Feature. In import_tfx_schema method, the domain info is first made inline so there is no need to have schema level domain info when updating Feast Entity and Feature. Also added documentation to setter property methods in Field.py * Fix rebase errors, apply black * Remove unnecessary imports Co-authored-by: zhilingc <zhiling.c@go-jek.com>
Refactor, document, and validate Feast Core Properties
Refactor FeastProperties to support nested store configuration
Localize all store configuration in Serving in Spring configuration
Various configuration updates
* Allow Feast Serving to use types properties instead of maps
* Reuse Feast Core Store model in serving
* Remove redundant config classes for Redis
* Update Serving Beans and Config classes to use ne1w configuration getters
* Remove hot-loading from store configuration. This reduces a bit of
flexibility, but simplifies the code and configuration
woop
force-pushed
the
configuration-refactor
branch
from
aa92244 to
03e5673
Compare
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
Closing this in favour of a local branch. |
woop
added
compat/breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is meant to resolve #525 and should be merged on only after the #567 and #533 PRs have been merged in.
The major changes will be that it will restructure and clean up Feast configuration properties in order for developers to find it easier to configure a Feast deployment and easier to know when it is misconfigured.
Which issue(s) this PR fixes:
Fixes #525
Does this PR introduce a user-facing change?: