feat: Add Chronon online and offline store integrations#6188
Draft
franciscojavierarceo wants to merge 3 commits intofeast-dev:masterfrom
Draft
feat: Add Chronon online and offline store integrations#6188franciscojavierarceo wants to merge 3 commits intofeast-dev:masterfrom
franciscojavierarceo wants to merge 3 commits intofeast-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds an in-tree optional Chronon integration to Feast and wires a Chronon-specific CI path for it.
The initial integration includes:
ChrononOnlineStorefor online reads through the Chronon feature serviceChrononOfflineStoreandChrononSourcefor Chronon-backed offline retrieval from materialized outputsChrononProviderregistration so Chronon can be selected as a Feast provider/store typeNotable details
A couple of issues only showed up once this was tested against the real Chronon service:
/v1/features/...quickstart/training_set.v2becomesquickstart%2Ftraining_set.v2Those fixes are included here.
Testing
Ran locally:
uv run pytest -c sdk/python/pytest.ini sdk/python/tests/unit/infra/online_stores/chronon_online_store/test_chronon_online_store.py -quv run pytest -c sdk/python/pytest.ini sdk/python/tests/unit/infra/offline_stores/contrib/chronon_offline_store/test_chronon_source.py -quv run pytest -c sdk/python/pytest.ini sdk/python/tests/integration/online_store/test_chronon_online_store.py sdk/python/tests/integration/offline_store/test_chronon_offline_store.py --integration -qJAVA_BIN=/opt/homebrew/opt/openjdk/bin/java infra/scripts/chronon/start-local-chronon-service.shCHRONON_SERVICE_URL=http://127.0.0.1:9000 uv run pytest -c sdk/python/pytest.ini sdk/python/tests/integration/online_store/test_chronon_online_store_real_service.py --integration -qinfra/scripts/chronon/stop-local-chronon-service.shFollow-ups
Open questions for follow-up PRs:
ChrononProvidershould stay as a thin passthrough or take on materialization/job orchestration