feat: Add SingleStore online store support for feature view versioning#6195
feat: Add SingleStore online store support for feature view versioning#6195antznette1 wants to merge 22 commits intofeast-dev:masterfrom
Conversation
88a6e5b to
0de8845
Compare
|
Good day @franciscojavierarceo |
ef34979 to
857d237
Compare
a197d10 to
6cd6eb7
Compare
|
@antznette1 Can you please take a look at #6193, it has shared helper added now for table name and pattern for deleting all versions in teardown ? |
c646964 to
b06b1ce
Compare
…singlestore.py Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
f97a997 to
8a64179
Compare
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
Conflicts has been fixed, can we proceed? |
|
@ntkathole , Please can I get a review to my PR? |
@antznette1 I mentioned this to see if we really need registry object passing down the calls or can be resolved with the same approach that PR to handle version cleanup ? |
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
|
@ntkathole |
franciscojavierarceo
left a comment
There was a problem hiding this comment.
can you elaborate on why some of the changes are included in this PR? feels like maybe some other items snuck in. 😅
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
My bad. |
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
|
Good day, |
|
Hello |
What this PR does / why we need it:
This PR adds online feature view versioning support for the SingleStore online store when
registry.enable_online_feature_view_versioningis enabled.It updates SingleStore’s table routing to read/write from versioned namespaces (e.g.
{project}_{feature_view}_v{N}) so version-qualified refs likedriver_stats@v1:avg_daily_tripscan be served from the correct underlying online table. It also updates the global online-store guard to allow version-qualified reads for SingleStore (and still reject unsupported stores) when versioning is enabled.Additionally, it adds an integration/universal test covering SingleStore version-qualified reads.
Which issue(s) this PR fixes:
Fixes #6181
Checks
git commit -s)Testing Strategy
Misc
Notes:
registry.enable_online_feature_view_versioningis enabled; otherwiseVersionedOnlineReadNotSupportedis raised.