feat: Migrate MCP server from fastapi_mcp to MCP Python SDK#6258
Open
patelchaitany wants to merge 1 commit intofeast-dev:masterfrom
Open
feat: Migrate MCP server from fastapi_mcp to MCP Python SDK#6258patelchaitany wants to merge 1 commit intofeast-dev:masterfrom
patelchaitany wants to merge 1 commit intofeast-dev:masterfrom
Conversation
patelchaitany
force-pushed
the
enh/mcp-sdk-migration
branch
from
3d6b581 to
6c098d6
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
patelchaitany
force-pushed
the
enh/mcp-sdk-migration
branch
from
6c098d6 to
092a808
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
patelchaitany
force-pushed
the
enh/mcp-sdk-migration
branch
5 times, most recently
from
f0a5d8b to
86780be
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
patelchaitany
force-pushed
the
enh/mcp-sdk-migration
branch
5 times, most recently
from
7accb30 to
8f2c53f
Compare
…nError on recursive Pydantic models, expose explicit @mcp.tool() handlers that call FeatureStore directly, and add registry discovery, data access, and materialization tools with flat LLM-friendly schemas. Signed-off-by: Chaitany patel <patelchaitany93@gmail.com> Rerun-CI: true
patelchaitany
force-pushed
the
enh/mcp-sdk-migration
branch
from
8f2c53f to
b34109b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6252
fastapi_mcphas no cycle detection inresolve_schema_references(). Any self-referencing Pydantic model in the OpenAPI schema (compound filters, nestedFilterExpression, etc.) causes aRecursionErrorthat takes down the whole MCP server. It also spits out$ref/$defs-heavy schemas that LLMs can't work with, and generates tool names from HTTP verbs (post_get_online_features).This swaps
fastapi_mcpfor the MCP Python SDK (FastMCP). Tools are registered with@mcp.tool()and callFeatureStoredirectly, no internal HTTP round-trip.What changed
mcp_server.py-- replacedFastApiMCPwrapper with acreate_mcp_server()function that registers tools explicitlylist_feature_views,list_entities,list_feature_services,list_data_sourcesget_online_features,search_documentsmaterialize,materialize_incrementalmcp_transportconfigmcp_base_path(default/mcp)