fix: Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling#6315
Open
jials wants to merge 8 commits intofeast-dev:masterfrom
Open
fix: Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling#6315jials wants to merge 8 commits intofeast-dev:masterfrom
jials wants to merge 8 commits intofeast-dev:masterfrom
Conversation
…stry._sync_feast_metadata_to_projects_table Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
…s in SnowflakeRegistry Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
…e test targets Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
…onnector.connect Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
SnowflakeRegistrycaused by premature attribute access during__init__settype hints — useset()instead of[]for set-typed variables in_sync_feast_metadata_to_projects_tableprivate_key,private_key_path,private_key_passphrase) before passing tosnowflake.connector.connect, preventing unexpected keyword argument errorsSnowflakeRegistrycache methodsexecute_snowflake_statementcall sites to avoid execution errorsproject_idscoping inget_user_metadataanddelete_projectsnowflake_registryfixture to integration registry testsSnowflakeRegistrywith xdist_group isolationsnowflake_registryto CI filter and exclude from non-Snowflake test targetsWhich issue(s) this PR fixes:
Fixes #5204
Checks
git commit -s)Testing Strategy
Misc
Key files changed:
sdk/python/feast/infra/registry/snowflake.py— core bug fixessdk/python/feast/infra/utils/snowflake/snowflake_utils.py— private key kwarg cleanupsdk/python/tests/unit/infra/registry/test_snowflake_registry.py— new unit test suitesdk/python/tests/integration/registration/test_universal_registry.py— integration fixtureMakefile/.github/workflows/— CI configuration for snowflake registry tests