fix: Handle numpy ndarray in Array(String) materialization#6327
Open
SIDDHESH1564 wants to merge 6 commits intofeast-dev:masterfrom
Open
fix: Handle numpy ndarray in Array(String) materialization#6327SIDDHESH1564 wants to merge 6 commits intofeast-dev:masterfrom
SIDDHESH1564 wants to merge 6 commits intofeast-dev:masterfrom
Conversation
Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>
Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>
db3a30b to
e754d58
Compare
Member
|
@SIDDHESH1564 dupe of #6324 ? Feel free to review other PR |
Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>
…change Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>
a7d3fc5 to
c77302a
Compare
Signed-off-by: Siddhesh Khairnar <khairnarsiddhesh4057@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Materializing feature views that contain
Array(String)columns using the Athena offline store fails withTypeErrororValueError.Root cause:
Arrow/Athena deserializes array columns as
numpy.ndarray(object dtype) instead of Python lists, which breaks assumptions infeast/type_map.py.Issues observed:
_validate_collection_item_types:Noneelements insidendarrayfail strict type validation._convert_list_values_to_proto: Passingnumpy.ndarraydirectly to protobuf constructors (e.g.StringList) raisesTypeError.Noneelements are also invalid for protobuf repeated fields._convert_scalar_values_to_proto:pd.isnull(ndarray)returns an array of booleans; applyingnotraisesValueError("truth value of an empty array is ambiguous").Fix implemented:
numpy.ndarray→ Pythonlistusing.tolist()before proto conversionNoneelements with type-appropriate defaults:""(string),0(int),0.0(float),False(bool)Noneduring intermediate validation in_validate_collection_item_typesWhich issue(s) this PR fixes:
Fixes #6325
Checks
git commit -s)Testing Strategy
Details:
Added
TestNdarrayListConversionintest_type_map.pywith regression coverage for:Noneelements with defaultsProtoValueNone+ empty array)Misc
Adds regression coverage to ensure stable handling of ndarray-backed array feature columns from Athena/Arrow going forward.