fix: Fix ValueError in signal handling for Trino worker threads#6428
Open
mbm-codes wants to merge 1 commit into
Open
fix: Fix ValueError in signal handling for Trino worker threads#6428mbm-codes wants to merge 1 commit into
mbm-codes wants to merge 1 commit into
Conversation
Signed-off-by: MBM <mihir105@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Guards
signal.signal()calls inQuery.__init__()with athreading.current_thread() is threading.main_thread()check.When the Trino offline store is served via Arrow Flight,
Query.__init__()runs in a worker thread. Python restrictssignal.signal()to the main thread only, causing:ValueError: signal only works in main thread of the main interpreterWhich issue(s) this PR fixes:
Fixes #6424
Checks
git commit -s)Testing Strategy
Misc
Added regression tests covering both main thread and worker thread scenarios.
Signal handling is preserved for CLI/interactive usage. Worker thread usage silently skips signal registration, which is the correct behavior when running under Arrow Flight.