feat: data change notify error handling#11
Merged
deleteLater merged 2 commits intomainfrom Nov 28, 2025
Merged
Conversation
deleteLater
changed the title
deleteLater
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds error handling for data change notifications when processing data synchronization messages. However, the implementation introduces a critical bug through the use of fire-and-forget pattern that can cause unobserved task exceptions.
Key Changes:
- Added try-catch error handling in DataChangeNotifier.NotifyAsync to gracefully handle exceptions from individual message handlers
- Changed NotifyItemsUpdated from awaited to fire-and-forget pattern in DataSyncMessageHandler (introduces critical bug)
- Renamed method from OnItemsUpdated to NotifyItemsUpdated to better reflect its purpose
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Api/Messaging/DataChangeNotifier.cs | Added try-catch block around handler.HandleAsync with proper error logging; improved log message from "Handled" to "Notified" |
| src/Api/DataSynchronizer/DataSyncMessageHandler.cs | Renamed method to NotifyItemsUpdated and converted to fire-and-forget pattern with discard operator (critical: creates unobserved task exception risk) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
deleteLater
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added error handling for data update notification
related to featbit/featbit#815