fix: broken images due to base URL changes#817
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes broken images by updating markdown files to use the Docusaurus useBaseUrl helper for asset paths.
- Replaces hardcoded image paths with useBaseUrl in branding, public API documentation, and blog posts.
- Ensures that image links in various language versions correctly resolve via base URL adjustments.
Reviewed Changes
Copilot reviewed 10 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| i18n/uz/docusaurus-plugin-content-docs/current/branding.md | Updated image URL paths using useBaseUrl |
| i18n/ru/docusaurus-plugin-content-docs/current/public-api.md | Updated image URL paths using useBaseUrl |
| i18n/ru/docusaurus-plugin-content-docs/current/branding.md | Updated image URL paths using useBaseUrl |
| i18n/kr/docusaurus-plugin-content-docs/current/public-api.md | Updated image URL paths using useBaseUrl |
| i18n/ja/docusaurus-plugin-content-docs/current/public-api.md | Updated image URL paths using useBaseUrl |
| i18n/ja/docusaurus-plugin-content-docs/current/branding.md | Updated image URL paths using useBaseUrl |
| i18n/en/docusaurus-plugin-content-docs/current/public-api.md | Updated image URL paths using useBaseUrl |
| i18n/en/docusaurus-plugin-content-docs/current/branding.md | Updated image URL paths using useBaseUrl |
| blog/2022-07-25-international-community.md | Updated image URL via useBaseUrl for correct linking |
| blog/2022-06-04-rebranding.md | Updated image URL via useBaseUrl for correct linking |
Files not reviewed (8)
- i18n/en/docusaurus-plugin-content-docs/current/reference/layers.mdx: Language not supported
- i18n/en/docusaurus-plugin-content-docs/current/reference/slices-segments.mdx: Language not supported
- i18n/ja/docusaurus-plugin-content-docs/current/reference/layers.mdx: Language not supported
- i18n/ja/docusaurus-plugin-content-docs/current/reference/slices-segments.mdx: Language not supported
- i18n/kr/docusaurus-plugin-content-docs/current/reference/slices-segments.mdx: Language not supported
- i18n/ru/docusaurus-plugin-content-docs/current/reference/layers.mdx: Language not supported
- i18n/ru/docusaurus-plugin-content-docs/current/reference/slices-segments.mdx: Language not supported
- i18n/uz/docusaurus-plugin-content-docs/current/reference/layers.mdx: Language not supported
Deploying pr-fsd with
|
| Latest commit: |
d15c523
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0af3d1b7.pr-fsd.pages.dev |
| Branch Preview URL: | https://fix-broken-images.pr-fsd.pages.dev |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…com:feature-sliced/documentation into fix-broken-images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Closes #816
Changelog
useBaseUrlin HTML-style images and links because Docusaurus: https://docusaurus.io/docs/static-assets#in-markdown