Skip to content

Remove rulemakings feature flag references#7064

Merged
rfultz merged 1 commit intorelease/public-20260407from
feature/6526-remove-rulemakings-feature-flag
Apr 8, 2026
Merged

Remove rulemakings feature flag references#7064
rfultz merged 1 commit intorelease/public-20260407from
feature/6526-remove-rulemakings-feature-flag

Conversation

@pkfec
Copy link
Copy Markdown
Contributor

@pkfec pkfec commented Apr 1, 2026

Summary (required)

Before, Rulemakings was behind a feature flag to expose the endpoint in lower environments. Now that Rulemakings went live on March 10, we should consider removing the feature flag from the openFEC and fec-cms codebase and also removing feature flag environment variables from the cloud.gov space across all three environments.

This PR removes the following three rulemaking feature flags that are currently referenced in the code:

  1. FEC_FEATURE_RULEMAKINGS
  2. FEC_FEATURE_RULEMAKINGS_SINGLE
  3. FEC_FEATURE_RULEMAKINGS_COMMENTING

Required reviewers

1-2 developers

How to test

  • unset rulemakings feature flags if already set in local workspace:
    - run: unset FEC_FEATURE_RULEMAKINGS
    - run: unset FEC_FEATURE_RULEMAKINGS_SINGLE
    - run: unset FEC_FEATURE_RULEMAKINGS_COMMENTING
  • run: git checkout feature/6526-remove-rulemakings-feature-flag
  • run: pyenv activate <cms virtual env>
  • run: pytest (on fec-cms dir )
  • run: cd fec
  • run: ./manage.py runserve
  • test rulemaking landing page, datatables, single rulemakings pages are loading OK (without rulemakings feature flags)

@pkfec pkfec changed the base branch from develop to release/public-20260407 April 1, 2026 21:05
@pkfec pkfec self-assigned this Apr 1, 2026
@pkfec pkfec moved this to 👀 Ready in Website project Apr 1, 2026
@pkfec pkfec force-pushed the feature/6526-remove-rulemakings-feature-flag branch from 9e1da32 to e44e6c8 Compare April 1, 2026 22:05
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.83%. Comparing base (0b0d40e) to head (10131a3).
⚠️ Report is 10 commits behind head on release/public-20260407.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           release/public-20260407    #7064      +/-   ##
===========================================================
- Coverage                    78.91%   78.83%   -0.09%     
===========================================================
  Files                          255      255              
  Lines                         6565     6557       -8     
===========================================================
- Hits                          5181     5169      -12     
- Misses                        1384     1388       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@rfultz rfultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (Any reason to keep the parens?)

else results['total_regulations'])

if settings.FEATURES['rulemakings'] and (result_type == 'all' or result_type == 'rulemakings'):
if (result_type == 'all' or result_type == 'rulemakings'):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the parens?

Copy link
Copy Markdown
Contributor Author

@pkfec pkfec Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfultz Good catch. I removed extra parnes from the if block. Thanks!

@pkfec pkfec force-pushed the feature/6526-remove-rulemakings-feature-flag branch from e44e6c8 to 10131a3 Compare April 8, 2026 13:53
@pkfec pkfec requested a review from rfultz April 8, 2026 13:56
Copy link
Copy Markdown
Contributor

@rfultz rfultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rfultz rfultz merged commit 593a6b9 into release/public-20260407 Apr 8, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from 👀 Ready to ✅ Done in Website project Apr 8, 2026
@rfultz rfultz deleted the feature/6526-remove-rulemakings-feature-flag branch April 8, 2026 14:18
@johnnyporkchops johnnyporkchops restored the feature/6526-remove-rulemakings-feature-flag branch April 9, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants