Remove rulemakings feature flag references#7064
Merged
rfultz merged 1 commit intorelease/public-20260407from Apr 8, 2026
Merged
Remove rulemakings feature flag references#7064rfultz merged 1 commit intorelease/public-20260407from
rfultz merged 1 commit intorelease/public-20260407from
Conversation
9e1da32 to
e44e6c8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/public-20260407 #7064 +/- ##
===========================================================
- Coverage 78.91% 78.83% -0.09%
===========================================================
Files 255 255
Lines 6565 6557 -8
===========================================================
- Hits 5181 5169 -12
- Misses 1384 1388 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rfultz
requested changes
Apr 7, 2026
Contributor
rfultz
left a comment
There was a problem hiding this comment.
Looks good! (Any reason to keep the parens?)
fec/legal/views.py
Outdated
| else results['total_regulations']) | ||
|
|
||
| if settings.FEATURES['rulemakings'] and (result_type == 'all' or result_type == 'rulemakings'): | ||
| if (result_type == 'all' or result_type == 'rulemakings'): |
Contributor
There was a problem hiding this comment.
Do we still need the parens?
Contributor
Author
There was a problem hiding this comment.
@rfultz Good catch. I removed extra parnes from the if block. Thanks!
e44e6c8 to
10131a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (required)
Before, Rulemakings was behind a feature flag to expose the endpoint in lower environments. Now that Rulemakings went live on March 10, we should consider removing the feature flag from the openFEC and fec-cms codebase and also removing feature flag environment variables from the cloud.gov space across all three environments.
This PR removes the following three rulemaking feature flags that are currently referenced in the code:
Required reviewers
1-2 developers
How to test
- run:
unset FEC_FEATURE_RULEMAKINGS- run:
unset FEC_FEATURE_RULEMAKINGS_SINGLE- run:
unset FEC_FEATURE_RULEMAKINGS_COMMENTINGgit checkout feature/6526-remove-rulemakings-feature-flagpyenv activate <cms virtual env>pytest(onfec-cmsdir )cd fec./manage.py runserve