Security: Missing ownership filter updates all users' followed tags#429
Closed
tomaioo wants to merge 1 commit into
Closed
Security: Missing ownership filter updates all users' followed tags#429tomaioo wants to merge 1 commit into
tomaioo wants to merge 1 commit into
Conversation
The follow/unfollow handlers update `accountOwners.followedTags` without a `WHERE` clause tied to the authenticated owner. As written, a single authenticated request modifies followed tags for every account owner in the database, causing cross-account data tampering. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
dahlia
requested changes
Apr 14, 2026
Member
dahlia
left a comment
dahlia
left a comment
There was a problem hiding this comment.
Thank you for catching and fixing this security issue!
This bug also exists in the 0.7-maintenance branch (our current stable release line), so we'd like to get this fix into a patch release as soon as possible. Could you please retarget this PR to 0.7-maintenance and rebase your changes onto it? After it's merged there, we'll forward-port the fix to main as well.
dahlia
added a commit
that referenced
this pull request
May 5, 2026
Added a changelog entry for the security vulnerability fix where the hashtag follow and unfollow API endpoints were missing an ownership filter. #429 Assisted-by: Claude Code:claude-sonnet-4-6
Member
|
Ported to and shipped with Hollo 0.7.14 and Hollo 0.8.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Missing ownership filter updates all users' followed tags
Problem
Severity:
High| File:src/api/v1/tags.ts:L28The follow/unfollow handlers update
accountOwners.followedTagswithout aWHEREclause tied to the authenticated owner. As written, a single authenticated request modifies followed tags for every account owner in the database, causing cross-account data tampering.Solution
Restrict updates to the authenticated account owner, e.g.
.where(eq(accountOwners.id, owner.id)). Also consider de-duplication and idempotency checks when appending tags.Changes
src/api/v1/tags.ts(modified)