Fix transfer type for Module.search_streams()#310
Merged
sgallagher merged 3 commits intofedora-modularity:masterfrom May 29, 2019
Merged
Fix transfer type for Module.search_streams()#310sgallagher merged 3 commits intofedora-modularity:masterfrom
sgallagher merged 3 commits intofedora-modularity:masterfrom
Conversation
Collaborator
Author
|
Note that the test does exercise this; if you attempt to run that test against an unmodified 2.5.0, you will see an error This is because the memory management frees the elements of the array unexpectedly. |
sgallagher
force-pushed
the
test_search_streams
branch
from
b1556ac to
9a2b0ca
Compare
This considerably reduces the time needed to perform the valgrind memory tests on systems with multiple available processors. In the case of my laptop, the duration was reduced from ~200s to 90s. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
sgallagher
force-pushed
the
test_search_streams
branch
4 times, most recently
from
f5aa28c to
223837d
Compare
Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Technically this is an API-breaking change, but no one is using it yet and it was always expected to be managed this way. Fixes: fedora-modularity#308 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
sgallagher
force-pushed
the
test_search_streams
branch
from
223837d to
6e7d928
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technically this is an API-breaking change, but no one is using it
yet and it was always expected to be managed this way.
Fixes: #308
Signed-off-by: Stephen Gallagher sgallagh@redhat.com