Specify distro for new Convertor test.#212
Merged
gordonmessmer merged 1 commit intofedora-python:masterfrom Sep 29, 2019
Merged
Specify distro for new Convertor test.#212gordonmessmer merged 1 commit intofedora-python:masterfrom
gordonmessmer merged 1 commit intofedora-python:masterfrom
Conversation
Member
|
I don't mind the change, but the tests blew up about spec2scl. |
Member
Author
|
I noticed that. I don't think it's related to changes in this project. It's probably the result of some change in spec2scl dropping support for py27. I'll look into it further as soon as I can. Since we plan to stop testing py27 anyway, we can probably just specify a maximum version for that package temporarily, until we get around to removing those tests. |
Member
Author
|
The problem occurred in a couple of different Travis builds, but I was unable to reproduce it in my own environment today. I restarted the Travis build, and it doesn't look like it's happening now. |
Member
Author
|
This change should resolve the test failures in 206 and 209. |
hroncok
approved these changes
Sep 29, 2019
gordonmessmer
added a commit
that referenced
this pull request
Sep 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 195 was merged, but did not have the "distro" argument in its tests, which is required since the merge of PR 199. This change fixes that deficiency.