This repository was archived by the owner on Apr 30, 2020. It is now read-only.
Fix unversioned shebangs check false positives #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mcyprian
commented
Aug 8, 2017
mcyprian
commented
- Prevent check failures in case the package requires /usr/bin/env, but doesn't contain any of the problematic shebangs, fixes Shebangs check reports false positives for packages requiring /usr/bin/env #31
- Add more log messages to the shebangs check to make debugging easier
hroncok
suggested changes
Aug 8, 2017
Member
hroncok
left a comment
hroncok
left a comment
There was a problem hiding this comment.
A few little nitpicks. Also, please use full URL of the issue in the commit message (in case we move to pagure or whatnot in the future).
Other than that, the fix itself looks OK. Thanks
| for shebang in FORBIDDEN_SHEBANGS: | ||
| if shebang_to_require(shebang) in package.require_names: | ||
| log.debug('Package {} requires {}'.format( | ||
| package.filename, shebang_to_require(shebang))) |
Member
There was a problem hiding this comment.
Since the require is bytes, this will be weird on Python 3:
>>> 'Package {} requires {}'.format('foo', b'/usr/bin/env')
"Package foo requires b'/usr/bin/env'"| docutils = fixtures_factory('_docutils') | ||
|
|
||
| _nodejs = fixtures_factory('nodejs-semver-5.1.1-2.fc26') | ||
| nodejs = fixtures_factory('_nodejs') |
Member
There was a problem hiding this comment.
Could you please add the new fixture to the first test, so all the downloading etc. happens at the beginning and all other tests happens at once?
mcyprian
force-pushed
the
unversioned_shebangs
branch
from
bc9c63d to
d11e6fc
Compare
Member
|
Thanks. Please autosquash and I'll approve and merge. |
added 2 commits
August 9, 2017 11:51
Prevent check failures in case the package requires /usr/bin/env, but doesn't contain any of the problematic shebangs. Resolves fedora-python#31.
mcyprian
force-pushed
the
unversioned_shebangs
branch
from
d11e6fc to
bdd7c87
Compare
Member
Author
|
Done. |
hroncok
approved these changes
Aug 9, 2017
Member
|
Merged to master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.