Decaffeination #196
Merged
Decaffeination #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we did this previously, all in one commit rather than individually.
also apply to lib/forward.js
Member
Author
|
At this point, with all the tests converted, we can run |
`git mv lib/defaultargs.coffee lib/defaultargs.js`
Member
Author
|
Currently no tests for search, but the serialised index file before and after decaffienation are identical so that suggests the code does the same thing. |
Member
Author
|
while all the tests pass, there are a few things that don't work. |
- Remove used variables and parameters.
- The code to remove the update flag had dropped outside an `else` block, add the missing {}.
fix the pair-wise splitting of lineup url into pages and locations fix the reversed element / index in iterating of the entries in urlPages
Add update author script, with prior authors Add require for should to test, that use it Make async tests async, and await supertest requests Remove grunt file, and related packages
The server used in the tests will continue running until the sitemap time ends. Add an arg for testing to use a much shorter timeout.
Member
Author
|
Grunt has now been removed. Tests are run with |
remove {}’s so name is returned.
should hasn’t been archived, so replace with node’s builtin assert. add support for `node —test`, this is not ready as there appears to be a timeout issue causing describe to fail even though all the tests have passed.
In `lib/server.js`, don’t set a default `process.exitCode` when running tests. So the tests don't report a failure when the server is closed. In `lib/sitemap.js`, the sitemap timeout is not relevant for the test environment.
The changes in this commit focus on improving the asynchronous behavior of the page tests. The main changes are: - Refactor the tests to use `async/await` syntax for better readability and error handling. - Add `return new Promise` blocks to ensure the tests wait for callbacks to complete.
Express 5 Upgrade
* fetch: replace node-fetch with native fetch api replace CoffeeScript template literals to JavaScript
Member
Author
|
Express.js updated to v5, and node-fetch replaced with native Fetch. also fixed CoffeeScript template literals that were missed. |
Remove glob-based plugin page search in favor of a pre-populated Map of plugin page locations built during initialization
Removing use of glob()
Deprecated
lib/page.js, lib/server.js updated to use modern Promise-based async/await pattern instead of the callback-based async.map. Async dependency removed from package.json.
Removing dependency on Async package
Member
Author
|
Use of glob replaced with use of node's Modules: CommonJS, this will change at some point when we switch to ECMAScript modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the server to JavaScript.
Tests are converted first, and use of grunt to run mocha retained (for now), as it is configured to allow the use of a mix of CoffeeScript and JavaScript.
CoffeeScript files are renamed using git mv so we can follow the git blame path back to the original CoffeeScript.
Post convertion we should review each dependency, taking into account advances in JavaScript and Node.
This is a restart of PR195 due to some strangeness with preservation of git history over the conversion.