Conversation
- 구현 - TypingServiceTest -> Entity 필드 변수가 변경되어 수정 사항을 반영했습니다. -> 회원, 비회원일 경우 타자 결과 응답으로 나타내는 요소들을 테스트합니다. (role, nickname, rank, luckyMessage) - 수정 - RankingControllerTest -> 공통 응답 객체 코드 변경(Array -> Map)에 따른 결과 타입을 변경하였습니다. -> sql 파일을 모든 메소드에 적용하기 위해서 @DirtiesContext 어노테이션을 활용했습니다. - RankingServiceTest, TypingRepositoryTest -> sql 파일을 모든 메소드에 적용하기 위해서 @DirtiesContext 어노테이션을 활용했습니다. -> 각 메소드가 실행되면서 DB에 저장된 데이터를 모두 지우기 위해서 tearDown 메소드를 사용했습니다. issue #20
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
#20
📝 작업 내용
TypingServiceTest
RankingControllerTest
RankingServiceTest, TypingRepositoryTest
💬 리뷰 요구사항