Skip to content

πŸ› Fix: 1μ°¨ MVP λͺ¨λΈ κΈ°λŠ₯ μˆ˜μ • 사항 반영 및 κ΅¬ν˜„#34

Merged
Bumnote merged 4 commits intodevfrom
fix/project-code
May 11, 2025
Merged

πŸ› Fix: 1μ°¨ MVP λͺ¨λΈ κΈ°λŠ₯ μˆ˜μ • 사항 반영 및 κ΅¬ν˜„#34
Bumnote merged 4 commits intodevfrom
fix/project-code

Conversation

@Bumnote
Copy link
Copy Markdown
Member

@Bumnote Bumnote commented May 11, 2025

#️⃣ μ—°κ΄€λœ 이슈

#31

πŸ“ μž‘μ—… λ‚΄μš©

  • OAuth 둜그인 성곡 μ‹œ, λ°±μ—”λ“œ μͺ½μ΄ μ•„λ‹Œ ν”„λ‘ νŠΈμ—”λ“œ λ‹¨μœΌλ‘œ Redirect 될 수 μžˆλ„λ‘ URL을 μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
  • OAuth 둜그인 μ‹€νŒ¨ μ‹œ, μ—λŸ¬ 처리λ₯Ό ν•˜κΈ° μœ„ν•΄μ„œ FailureHanlder λ‘œμ§μ„ κ΅¬ν˜„ν•˜μ—¬ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • λ‹‰λ„€μž„ 검증 Rest Controller API μ—”λ“œ ν¬μΈνŠΈμ— λˆ„λ½λœ 뢀뢄을 μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
  • λ°±μ—”λ“œ λ‹¨μ—μ„œ Header에 λ‹΄μ•„ 보낸 JWT 토큰에 μ ‘κ·Όν•  수 μžˆλ„λ‘ WebConfig 섀정을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ’¬ 리뷰 μš”κ΅¬μ‚¬ν•­

리뷰어가 νŠΉλ³„νžˆ λ΄μ£Όμ—ˆμœΌλ©΄ ν•˜λŠ” 뢀뢄이 μžˆλ‹€λ©΄ μž‘μ„±ν•΄μ£Όμ„Έμš”

Bumnote added 4 commits May 11, 2025 15:32
@Bumnote
πŸ› Fix: OAuth2AuthenticationSuccessHandler ν”„λ‘ νŠΈμ—”λ“œ Redirect μ—”λ“œν¬μΈνŠΈ μˆ˜μ •
3537458 
- OAuth 둜그인 성곡 μ‹œ, λ°±μ—”λ“œ μ„œλ²„λ₯Ό κΈ°μ€€μœΌλ‘œ Redirect ν–ˆμ„ λ•Œ, ν”„λ‘ νŠΈμ—”λ“œμ—μ„œ 토큰 값을 받을 수 μ—†λ‹€λŠ” 것을 κΉ¨λ‹¬μ•˜μŠ΅λ‹ˆλ‹€.
- λ”°λΌμ„œ, ν”„λ‘ νŠΈμ—”λ“œμ—μ„œ 성곡 토큰을 μΈμ‹ν•˜κΈ° μœ„ν•΄μ„œ Redirect μ—”λ“œν¬μΈνŠΈλ₯Ό μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

issue #31
@Bumnote
✨ Feat: OAuth 둜그인 μ‹€νŒ¨ν•  경우 Handler 둜직 κ΅¬ν˜„
e9ae507 
- OAuth2 둜그인 μ„±κ³΅ν•˜λŠ” 상황에 λŒ€ν•œ Handler λ‘œμ§μ€ μžˆμ§€λ§Œ, μ‹€νŒ¨ν•˜λŠ” 상황에 λŒ€ν•œ λ‘œμ§μ€ μ—†μ—ˆμŠ΅λ‹ˆλ‹€.
- OAuth2AuthenticationFailureHandler κ΅¬ν˜„ν•˜μ—¬ ν”„λ‘ νŠΈμ—”λ“œ μ—”λ“œ ν¬μΈνŠΈμ—μ„œ μ—λŸ¬ νŽ˜μ΄μ§€λ‘œ 보낼 수 μžˆλ„λ‘ κ΅¬ν˜„ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
- μ„±κ³΅ν•˜λŠ” 경우 -> ?success={token}
- μ‹€νŒ¨ν•˜λŠ” 경우 -> ?error={encodigMessage}
- λ‘œκ·ΈμΈμ„ μ‹€νŒ¨ν•˜λŠ” 상황에 FailureHandler 둜직으둜 이동할 수 μžˆκ²Œλ” SecurityConfig μ„€μ • λ˜ν•œ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

issue #31
@Bumnote
πŸ› Fix: λ‹‰λ„€μž„ 검증 Controller API μ—”λ“œ 포인트 μˆ˜μ •
bfe890b 
- λ‹‰λ„€μž„ 검증 Controller API μ—”λ“œ 포인트λ₯Ό 잘λͺ» μž‘μ„±ν•˜μ—¬ 이λ₯Ό μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

issue #31
@Bumnote
πŸ› Fix: ν”„λ‘ νŠΈμ—”λ“œ λ‹¨μ—μ„œ Header μ ‘κ·Ό κ°€λŠ₯ν•˜λ„λ‘ μˆ˜μ •
423e0f8 
- λ°±μ—”λ“œμ—μ„œ Header에 λ‹΄μ•„μ„œ λ³΄λ‚΄λŠ” JWT 토큰을 ν”„λ‘ νŠΈμ—”λ“œ λ‹¨μ—μ„œ μ ‘κ·Ό κ°€λŠ₯ν•˜λ„λ‘ μ½”λ“œλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

issue #31
@Bumnote Bumnote requested a review from kyubumjang May 11, 2025 06:51
@Bumnote Bumnote self-assigned this May 11, 2025
@Bumnote Bumnote merged commit 86b91f0 into dev May 11, 2025
@Bumnote Bumnote linked an issue May 11, 2025 that may be closed by this pull request
[Fix] 1μ°¨ MVP λͺ¨λΈ κΈ°λŠ₯ μˆ˜μ • 사항 #31
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyubumjang kyubumjang Awaiting requested review from kyubumjang

Assignees

@Bumnote Bumnote

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Fix] 1μ°¨ MVP λͺ¨λΈ κΈ°λŠ₯ μˆ˜μ • 사항

1 participant

@Bumnote