Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 25, 2022

The LightGBMBinaryClassificationModelTrainerTest shouldn't be ignored. For some reason it stopped failing so we'll simply erase the @ignore annotation.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #119 (c6719b9) into master (cb6105c) will increase coverage by 0.60%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #119      +/-   ##
============================================
+ Coverage     79.30%   79.90%   +0.60%     
- Complexity      424      428       +4     
============================================
  Files            43       43              
  Lines          1498     1498              
  Branches        138      138              
============================================
+ Hits           1188     1197       +9     
+ Misses          231      224       -7     
+ Partials         79       77       -2     
Impacted Files Coverage Δ
...feedzai/openml/provider/lightgbm/LightGBMSWIG.java 79.68% <0.00%> (+1.56%) ⬆️
...tgbm/LightGBMBinaryClassificationModelTrainer.java 86.86% <0.00%> (+2.91%) ⬆️
...openml/provider/lightgbm/LightGBMModelCreator.java 87.23% <0.00%> (+3.19%) ⬆️
...er/lightgbm/LightGBMBinaryClassificationModel.java 60.86% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6105c...c6719b9. Read the comment docs.

@ghost ghost changed the title Stop ignoring test Stop ignoring LightGBMBinaryClassificationModelTrainerTest May 25, 2022
@ghost ghost marked this pull request as ready for review May 25, 2022 13:50
@AlbertoEAF
Copy link
Contributor

Great news guys! Can we squash+merge already? 🙏 @mlobofeedzai @antssilva96

This will already be useful for @AndreFCruz 's work

@ghost ghost merged commit d6d464b into master May 26, 2022
@ghost ghost deleted the bf-ml-PULSEDEV-36792-experiment-3 branch May 26, 2022 14:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants