Remove fat-jars and update dependencies #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiagoMSSantos
force-pushed
the
ft-ts-bump-dependencies
branch
from
005c1f0 to
a857afb
Compare
samyuh
approved these changes
Oct 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=========================================
Coverage 80.37% 80.37%
Complexity 469 469
=========================================
Files 48 48
Lines 1620 1620
Branches 157 157
=========================================
Hits 1302 1302
Misses 231 231
Partials 87 87 |
TiagoMSSantos
force-pushed
the
ft-ts-bump-dependencies
branch
from
a857afb to
4822b1c
Compare
TiagoMSSantos
changed the title
TiagoMSSantos
force-pushed
the
ft-ts-bump-dependencies
branch
from
4822b1c to
aa7402e
Compare
samyuh
approved these changes
Oct 13, 2023
|
LGTM |
TiagoMSSantos
force-pushed
the
ft-ts-bump-dependencies
branch
4 times, most recently
from
8b1396f to
e0bbd1f
Compare
This commit removes the distribution of fat-jars with all the dependencies because OpenML-Java is a library and thus it's better to distribute it as such, and the project using it, can exclude some dependencies if it requires. It also updates some dependencies, that can be safely updated without breaking anything. It updates: * gson to v2.9.0 * slf4j-api to v1.7.36 * commons-lang3 to v3.13.0 * log4j to v2.20.0
TiagoMSSantos
force-pushed
the
ft-ts-bump-dependencies
branch
from
e0bbd1f to
7b3b9a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the distribution of fat-jars with all the dependencies
because OpenML-Java is a library and thus it's better to distribute it as such,
and the project using it, can exclude some dependencies if it requires.
It also updates some dependencies, that can be safely updated without
breaking anything. It updates: