LightGBM model locale fix#53
Merged
AlbertoEAF merged 32 commits intomasterfrom Sep 30, 2020
Merged
Conversation
added 7 commits
September 11, 2020 20:13
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
============================================
+ Coverage 78.46% 79.25% +0.78%
- Complexity 369 382 +13
============================================
Files 39 39
Lines 1333 1364 +31
Branches 123 127 +4
============================================
+ Hits 1046 1081 +35
+ Misses 221 215 -6
- Partials 66 68 +2
Continue to review full report at Codecov.
|
shengwangsw
reviewed
Sep 25, 2020
Contributor
Author
|
I actually have one question @shenggwang @paulojrp , I added the folder
Finally, the tests generate a new folder: |
paulojrp
reviewed
Sep 25, 2020
paulojrp
reviewed
Sep 25, 2020
shengwangsw
reviewed
Sep 28, 2020
shengwangsw
reviewed
Sep 28, 2020
paulojrp
reviewed
Sep 28, 2020
Contributor
Author
|
@shenggwang do we need the dummy |
AlbertoEAF
commented
Sep 29, 2020
Contributor
There is no See https://github.com/feedzai/feedzai-openml-java/tree/master/openml-lightgbm/lightgbm-builder |
paulojrp
approved these changes
Sep 30, 2020
shengwangsw
approved these changes
Sep 30, 2020
jlazevedo
pushed a commit
that referenced
this pull request
Dec 2, 2020
This implements the fix for model locale with Feedzai's patch to LightGBM v3.0.0. Such patch currently lives at feedzai/LightGBM as it wasn't yet merged to Microsoft's mainline code. Also, it integrates the latest version of make-lightgbm with support for build caches to speed up repeated builds of LightGBM.
jlazevedo
pushed a commit
that referenced
this pull request
Dec 2, 2020
This implements the fix for model locale with Feedzai's patch to LightGBM v3.0.0. Such patch currently lives at feedzai/LightGBM as it wasn't yet merged to Microsoft's mainline code. Also, it integrates the latest version of make-lightgbm with support for build caches to speed up repeated builds of LightGBM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the fix for model locale with our own patch to LightGBM v3.0.0.
Such patch currently lives at feedzai/LightGBM as it wasn't yet merged to Microsoft's mainline code.