fix: use requests library for font downloads and update URLs #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch from urllib to requests for better redirect handling - Update Roboto Mono URL to GitHub archive (Google Fonts URL broken) - Add Roboto font as default - Move Marianne to optional (Cloudflare blocks automated downloads) Closes #12
prudhomm
force-pushed
the
12-fix-font-download
branch
from
8694dec to
755d78a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix font download issues in v1.3.0.
Problem
fonts.google.com/downloadURL returns HTML instead of a zip fileSolution
urllibtorequestslibrary for better redirect and header handlingTesting
Closes #12