resolves: 276 Memory constraint not correctly taken into account #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for benchmarking-polite-crostata-92f389 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vincentchabannes
approved these changes
Mar 20, 2025
vincentchabannes
deleted the
276-memory-constraint-not-correctly-taken-into-account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that, if memory provided, the number of nodes was determined from the number of tasks per node.
The proposed solution hard sets
--nodeson the slurm script, and forces num_tasks_per_node to None on ReFrame.This way, SLURM is responsible of distributing tasks across nodes.
❗ WARNING ❗
Possible issue: this does not ensure that it will work for scheduler other than SLURM.