Skip to content

Feature/deim#1135

Merged
prudhomm merged 51 commits intodevelopfrom
feature/deim
Apr 3, 2018
Merged

Feature/deim#1135
prudhomm merged 51 commits intodevelopfrom
feature/deim

Conversation

@jbwahl
Copy link
Copy Markdown
Contributor

@jbwahl jbwahl commented Mar 27, 2018

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution?

Last development in DEIM framework:

jbwahl added 30 commits October 19, 2017 12:35
…polynomial orders vectorial or scalar and for matrix and vector
…ic assembly. This option is necessary when you use block structure with deim.

@romainhild
Also working for composite spaces
Not tested for block problems
@jbwahl jbwahl requested a review from vincentchabannes March 27, 2018 22:06
@jbwahl jbwahl assigned romainhild and unassigned romainhild Mar 27, 2018
@jbwahl jbwahl requested a review from romainhild March 27, 2018 22:06
@jbwahl
Copy link
Copy Markdown
Contributor Author

jbwahl commented Mar 27, 2018

@romainhild @vincentchabannes I am done with that feature.
If everything is ok for both of you, we can merge.

@jbwahl
Copy link
Copy Markdown
Contributor Author

jbwahl commented Apr 3, 2018

This merge will close #925 and close #974 close #866

@prudhomm
Copy link
Copy Markdown
Member

prudhomm commented Apr 3, 2018

@jbwahl could you edit the description and add the list of issues this PR is dealing with ?
thanks in advance

@jbwahl
Copy link
Copy Markdown
Contributor Author

jbwahl commented Apr 3, 2018

@prudhomm is description ok for you ?

@jbwahl
Copy link
Copy Markdown
Contributor Author

jbwahl commented Apr 3, 2018

@prudhomm all good here. Ready to merge.

@prudhomm prudhomm added this to the v0.104 milestone Apr 3, 2018
@prudhomm prudhomm merged commit aad2247 into develop Apr 3, 2018
@romainhild romainhild deleted the feature/deim branch October 23, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants